Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves error handling for
SCollection.unionAllwhen called with empty collections by providing a clear, actionable error message that guides users to the appropriate API.Problem
The
SCollection.unionAllmethod throws an unclear exception when called with an empty collection, leaving users confused about the correct approach. Meanwhile,ScioContext.unionAllproperly handles empty collections but users weren't aware of this alternative.Solution
SCollection.unionAllnow throws anIllegalArgumentExceptionwith a clear message pointing users toScioContext.unionAllfor empty-safe operationsChanges
SCollection.unionAllto provide descriptive error message for empty inputSCollection.unionAllandScioContext.unionAllTesting
ScioContext.unionAllcontinues to handle empty collections correctlyBackwards Compatibility
This change is backwards compatible - it only improves the error message for a previously failing case. No existing working code is affected.
Related Issues
Fixes #1092